From 610bc34bd2c70566c0af7f1856c4ab1dcf0029d2 Mon Sep 17 00:00:00 2001 From: Paul-Christian Volkmer Date: Fri, 17 Mar 2023 11:16:28 +0100 Subject: Verwende Factory, damit OS-API nicht beim Starten Einstellungen abrufen muss Beim Start kann OS ggf nicht auf die Einstellungen zurückgreifen, da die Datenbankverbindung noch nicht fertig initialisiert ist. Aus diesem Grund muss die konkrete Implementierung des TherapieplanService zur Laufzeit nach dem vollständigen Start von OS ermittelt werden. --- .../java/DNPM/config/PluginConfigurationTest.java | 45 ++-------------------- 1 file changed, 4 insertions(+), 41 deletions(-) (limited to 'src/test/java/DNPM/config/PluginConfigurationTest.java') diff --git a/src/test/java/DNPM/config/PluginConfigurationTest.java b/src/test/java/DNPM/config/PluginConfigurationTest.java index 811e583..77c95e7 100644 --- a/src/test/java/DNPM/config/PluginConfigurationTest.java +++ b/src/test/java/DNPM/config/PluginConfigurationTest.java @@ -1,8 +1,7 @@ package DNPM.config; -import DNPM.services.DefaultTherapieplanService; import DNPM.services.FormService; -import DNPM.services.MultipleMtbTherapieplanService; +import DNPM.services.TherapieplanServiceFactory; import de.itc.onkostar.api.IOnkostarApi; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -11,9 +10,6 @@ import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; import static org.assertj.core.api.Assertions.assertThat; -import static org.mockito.ArgumentMatchers.anyString; -import static org.mockito.Mockito.doAnswer; -import static org.mockito.Mockito.when; @ExtendWith(MockitoExtension.class) public class PluginConfigurationTest { @@ -32,41 +28,8 @@ public class PluginConfigurationTest { } @Test - void testShouldReturnDefaultTherapieplanServiceIfSettingIsFalse() { - doAnswer(invocationOnMock -> { - var settingName = invocationOnMock.getArgument(0, String.class); - if (settingName.equals("mehrere_mtb_in_mtbepisode")) { - return "false"; - } - return null; - }).when(onkostarApi).getGlobalSetting(anyString()); - - var actual = this.configuration.therapieplanService(onkostarApi, formService); - - assertThat(actual).isInstanceOf(DefaultTherapieplanService.class); - } - - @Test - void testShouldReturnDefaultTherapieplanServiceIfNoSetting() { - when(onkostarApi.getGlobalSetting(anyString())).thenReturn(null); - - var actual = this.configuration.therapieplanService(onkostarApi, formService); - - assertThat(actual).isInstanceOf(DefaultTherapieplanService.class); - } - - @Test - void testShouldReturnMultipleMtbTherapieplanServiceIfSettingIsTrue() { - doAnswer(invocationOnMock -> { - var settingName = invocationOnMock.getArgument(0, String.class); - if (settingName.equals("mehrere_mtb_in_mtbepisode")) { - return "true"; - } - return null; - }).when(onkostarApi).getGlobalSetting(anyString()); - - var actual = this.configuration.therapieplanService(onkostarApi, formService); - - assertThat(actual).isInstanceOf(MultipleMtbTherapieplanService.class); + void testShouldReturnTherapieplanServiceFactory() { + var actual = this.configuration.therapieplanServiceFactory(onkostarApi, formService); + assertThat(actual).isInstanceOf(TherapieplanServiceFactory.class); } } -- cgit v1.2.3