From fb91356b7777dfa5b6088bcc3a48b43924c1c0fd Mon Sep 17 00:00:00 2001
From: Paul-Christian Volkmer
Date: Thu, 3 Sep 2026 14:35:10 +0200
Subject: build: apply Spotless plugin (#293)

---
 .../PersonPoolBasedSecurityAspectsTest.java        | 279 +++++++++++----------
 1 file changed, 141 insertions(+), 138 deletions(-)

(limited to 'src/test/java/dev/dnpm/oshelper/security/PersonPoolBasedSecurityAspectsTest.java')

diff --git a/src/test/java/dev/dnpm/oshelper/security/PersonPoolBasedSecurityAspectsTest.java b/src/test/java/dev/dnpm/oshelper/security/PersonPoolBasedSecurityAspectsTest.java
index 4f03a64..cf7706c 100644
--- a/src/test/java/dev/dnpm/oshelper/security/PersonPoolBasedSecurityAspectsTest.java
+++ b/src/test/java/dev/dnpm/oshelper/security/PersonPoolBasedSecurityAspectsTest.java
@@ -19,6 +19,10 @@
 
 package dev.dnpm.oshelper.security;
 
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.*;
+
 import de.itc.onkostar.api.IOnkostarApi;
 import de.itc.onkostar.api.Patient;
 import de.itc.onkostar.api.Procedure;
@@ -29,154 +33,153 @@ import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.springframework.aop.aspectj.annotation.AspectJProxyFactory;
 
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.mockito.Mockito.*;
-
 @ExtendWith(MockitoExtension.class)
 class PersonPoolBasedSecurityAspectsTest {
 
-    private DummyClass dummyClass;
-
-    private IOnkostarApi onkostarApi;
-
-    private PersonPoolBasedPermissionEvaluator permissionEvaluator;
-
-    @BeforeEach
-    void setup(
-            @Mock IOnkostarApi onkostarApi,
-            @Mock PersonPoolBasedPermissionEvaluator permissionEvaluator
-    ) {
-        this.onkostarApi = onkostarApi;
-        this.permissionEvaluator = permissionEvaluator;
-
-        // Create proxied instance of DummyClass as done within Onkostar using Spring AOP
-        var dummyClass = new DummyClass(onkostarApi);
-        AspectJProxyFactory factory = new AspectJProxyFactory(dummyClass);
-        PersonPoolBasedSecurityAspects securityAspects = new PersonPoolBasedSecurityAspects(this.permissionEvaluator);
-        factory.addAspect(securityAspects);
-        this.dummyClass = factory.getProxy();
+  private DummyClass dummyClass;
+
+  private IOnkostarApi onkostarApi;
+
+  private PersonPoolBasedPermissionEvaluator permissionEvaluator;
+
+  @BeforeEach
+  void setup(
+      @Mock IOnkostarApi onkostarApi,
+      @Mock PersonPoolBasedPermissionEvaluator permissionEvaluator) {
+    this.onkostarApi = onkostarApi;
+    this.permissionEvaluator = permissionEvaluator;
+
+    // Create proxied instance of DummyClass as done within Onkostar using Spring AOP
+    var dummyClass = new DummyClass(onkostarApi);
+    AspectJProxyFactory factory = new AspectJProxyFactory(dummyClass);
+    PersonPoolBasedSecurityAspects securityAspects =
+        new PersonPoolBasedSecurityAspects(this.permissionEvaluator);
+    factory.addAspect(securityAspects);
+    this.dummyClass = factory.getProxy();
+  }
+
+  @Test
+  void testShouldPreventSecuredMethodCallWithPatientParam() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Patient.class), any(PermissionType.class)))
+        .thenReturn(false);
+
+    var exception =
+        assertThrows(
+            Exception.class,
+            () -> this.dummyClass.methodWithPatientParam(new Patient(onkostarApi)));
+    assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+  }
+
+  @Test
+  void testShouldAllowSecuredMethodCallWithPatientParam() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Patient.class), any(PermissionType.class)))
+        .thenReturn(true);
+
+    this.dummyClass.methodWithPatientParam(new Patient(onkostarApi));
+
+    verify(onkostarApi, times(1)).savePatient(any(Patient.class));
+  }
+
+  @Test
+  void testShouldPreventSecuredMethodCallWithProcedureParam() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Procedure.class), any(PermissionType.class)))
+        .thenReturn(false);
+
+    var exception =
+        assertThrows(
+            Exception.class,
+            () -> this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi)));
+    assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+  }
+
+  @Test
+  void testShouldAllowSecuredMethodCallWithProcedureParam() throws Exception {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Procedure.class), any(PermissionType.class)))
+        .thenReturn(true);
+
+    this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi));
+
+    verify(onkostarApi, times(1)).saveProcedure(any(Procedure.class), anyBoolean());
+  }
+
+  @Test
+  void testShouldPreventSecuredMethodCallWithPatientReturnValue() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Patient.class), any(PermissionType.class)))
+        .thenReturn(false);
+
+    var exception =
+        assertThrows(Exception.class, () -> this.dummyClass.methodWithPatientReturnValue(1));
+    assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+  }
+
+  @Test
+  void testShouldAllowSecuredMethodCallWithPatientReturnValue() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Patient.class), any(PermissionType.class)))
+        .thenReturn(true);
+
+    var actual = this.dummyClass.methodWithPatientReturnValue(1);
+
+    assertThat(actual).isNotNull();
+  }
+
+  @Test
+  void testShouldPreventSecuredMethodCallWithProcedureReturnValue() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Procedure.class), any(PermissionType.class)))
+        .thenReturn(false);
+
+    var exception =
+        assertThrows(Exception.class, () -> this.dummyClass.methodWithProcedureReturnValue(1));
+    assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+  }
+
+  @Test
+  void testShouldAllowSecuredMethodCallWithProcedureReturnValue() {
+    when(this.permissionEvaluator.hasPermission(
+            any(), any(Procedure.class), any(PermissionType.class)))
+        .thenReturn(true);
+
+    var actual = this.dummyClass.methodWithProcedureReturnValue(1);
+
+    assertThat(actual).isNotNull();
+  }
+
+  private static class DummyClass {
+
+    private final IOnkostarApi onkostarApi;
+
+    DummyClass(final IOnkostarApi onkostarApi) {
+      this.onkostarApi = onkostarApi;
     }
 
-    @Test
-    void testShouldPreventSecuredMethodCallWithPatientParam() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Patient.class), any(PermissionType.class)))
-                .thenReturn(false);
-
-        var exception = assertThrows(
-                Exception.class,
-                () -> this.dummyClass.methodWithPatientParam(new Patient(onkostarApi))
-        );
-        assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+    @PersonPoolSecured
+    public void methodWithPatientParam(Patient patient) {
+      this.onkostarApi.savePatient(patient);
     }
 
-    @Test
-    void testShouldAllowSecuredMethodCallWithPatientParam() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Patient.class), any(PermissionType.class)))
-                .thenReturn(true);
-
-        this.dummyClass.methodWithPatientParam(new Patient(onkostarApi));
-
-        verify(onkostarApi, times(1)).savePatient(any(Patient.class));
+    @PersonPoolSecured
+    public void methodWithProcedureParam(Procedure procedure) throws Exception {
+      this.onkostarApi.saveProcedure(procedure, false);
     }
 
-    @Test
-    void testShouldPreventSecuredMethodCallWithProcedureParam() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
-                .thenReturn(false);
-
-        var exception = assertThrows(
-                Exception.class,
-                () -> this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi))
-        );
-        assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
+    @PersonPoolSecuredResult
+    public Patient methodWithPatientReturnValue(int id) {
+      var patient = new Patient(this.onkostarApi);
+      patient.setId(id);
+      return patient;
     }
 
-    @Test
-    void testShouldAllowSecuredMethodCallWithProcedureParam() throws Exception {
-        when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
-                .thenReturn(true);
-
-        this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi));
-
-        verify(onkostarApi, times(1)).saveProcedure(any(Procedure.class), anyBoolean());
+    @PersonPoolSecuredResult
+    public Procedure methodWithProcedureReturnValue(int id) {
+      var procedure = new Procedure(this.onkostarApi);
+      procedure.setId(id);
+      return procedure;
     }
-
-    @Test
-    void testShouldPreventSecuredMethodCallWithPatientReturnValue() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Patient.class), any(PermissionType.class)))
-                .thenReturn(false);
-
-        var exception = assertThrows(
-                Exception.class,
-                () -> this.dummyClass.methodWithPatientReturnValue(1)
-        );
-        assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
-    }
-
-    @Test
-    void testShouldAllowSecuredMethodCallWithPatientReturnValue() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Patient.class), any(PermissionType.class)))
-                .thenReturn(true);
-
-        var actual = this.dummyClass.methodWithPatientReturnValue(1);
-
-        assertThat(actual).isNotNull();
-    }
-
-    @Test
-    void testShouldPreventSecuredMethodCallWithProcedureReturnValue() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
-                .thenReturn(false);
-
-        var exception = assertThrows(
-                Exception.class,
-                () -> this.dummyClass.methodWithProcedureReturnValue(1)
-        );
-        assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
-    }
-
-    @Test
-    void testShouldAllowSecuredMethodCallWithProcedureReturnValue() {
-        when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
-                .thenReturn(true);
-
-        var actual = this.dummyClass.methodWithProcedureReturnValue(1);
-
-        assertThat(actual).isNotNull();
-    }
-
-    private static class DummyClass {
-
-        private final IOnkostarApi onkostarApi;
-
-        DummyClass(final IOnkostarApi onkostarApi) {
-            this.onkostarApi = onkostarApi;
-        }
-
-        @PersonPoolSecured
-        public void methodWithPatientParam(Patient patient) {
-            this.onkostarApi.savePatient(patient);
-        }
-
-        @PersonPoolSecured
-        public void methodWithProcedureParam(Procedure procedure) throws Exception {
-            this.onkostarApi.saveProcedure(procedure, false);
-        }
-
-        @PersonPoolSecuredResult
-        public Patient methodWithPatientReturnValue(int id) {
-            var patient = new Patient(this.onkostarApi);
-            patient.setId(id);
-            return patient;
-        }
-
-        @PersonPoolSecuredResult
-        public Procedure methodWithProcedureReturnValue(int id) {
-            var procedure = new Procedure(this.onkostarApi);
-            procedure.setId(id);
-            return procedure;
-        }
-    }
-
+  }
 }
-- 
cgit v1.2.3