From 37314fca05468a3bfa8d4c3d23584586463a97fa Mon Sep 17 00:00:00 2001 From: Paul-Christian Volkmer Date: Mon, 7 Sep 2026 15:15:19 +0200 Subject: feat!: only add level 4/5 ATC codes (#295) ATC codes like `L`, `L01`, `L01E` are not imported any more and cannot be used as ATC code from database. These codes (from database) will be treated as unregistered code instead.--- src/test/java/dev/dnpm/oshelper/atc/AtcCodeTest.java | 8 ++++++-- src/test/java/dev/dnpm/oshelper/atc/CsvAgentCodeServiceTest.java | 9 +++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) (limited to 'src/test/java/dev/dnpm/oshelper') diff --git a/src/test/java/dev/dnpm/oshelper/atc/AtcCodeTest.java b/src/test/java/dev/dnpm/oshelper/atc/AtcCodeTest.java index 35fd34e..cab7afd 100644 --- a/src/test/java/dev/dnpm/oshelper/atc/AtcCodeTest.java +++ b/src/test/java/dev/dnpm/oshelper/atc/AtcCodeTest.java @@ -28,8 +28,6 @@ class AtcCodeTest { @Test void testShouldDetectAtcCodeScheme() { - assertTrue(AtcCode.isAtcCode("L01")); - assertTrue(AtcCode.isAtcCode("L01A")); assertTrue(AtcCode.isAtcCode("L01AA")); assertTrue(AtcCode.isAtcCode("L01AA01")); } @@ -43,4 +41,10 @@ class AtcCodeTest { assertFalse(AtcCode.isAtcCode("Z01AA")); assertFalse(AtcCode.isAtcCode("L01AA0")); } + + @Test + void testShouldNotAcceptAtcCodeShorterThanLevel4Or5() { + assertFalse(AtcCode.isAtcCode("L01")); + assertFalse(AtcCode.isAtcCode("L01A")); + } } diff --git a/src/test/java/dev/dnpm/oshelper/atc/CsvAgentCodeServiceTest.java b/src/test/java/dev/dnpm/oshelper/atc/CsvAgentCodeServiceTest.java index 82fd837..3877c9a 100644 --- a/src/test/java/dev/dnpm/oshelper/atc/CsvAgentCodeServiceTest.java +++ b/src/test/java/dev/dnpm/oshelper/atc/CsvAgentCodeServiceTest.java @@ -24,6 +24,8 @@ import static org.assertj.core.api.Assertions.assertThat; import dev.dnpm.oshelper.atc.services.AgentCodeService; import dev.dnpm.oshelper.atc.services.CsvAgentCodeService; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; class CsvAgentCodeServiceTest { @@ -36,4 +38,11 @@ class CsvAgentCodeServiceTest { assertThat(actual).hasSize(1); assertThat(actual.get(0).getCode()).isEqualTo("L01XA01"); } + + @ParameterizedTest + @ValueSource(strings = {"L", "L01", "L01E"}) + void shouldNotReturnIgnoredAtcCodeLevels(String code) { + var actual = agentCodeService.getAgentCode(code); + assertThat(actual).isEmpty(); + } } -- cgit v1.2.3