diff options
| author | Paul-Christian Volkmer | 2023-12-05 14:22:02 +0100 |
|---|---|---|
| committer | Paul-Christian Volkmer | 2023-12-05 14:24:40 +0100 |
| commit | ced6609d9ab75b42304df8888b1564a1a1795a5b (patch) | |
| tree | a3daeea96e190cc60c23c3b51b454da6c95b1f7f | |
| parent | 8dee349c377ebebba7e6a3633f71cf2c3e48183d (diff) | |
fix: add info severity to data quality report
4 files changed, 19 insertions, 2 deletions
diff --git a/src/main/kotlin/dev/dnpm/etl/processor/monitoring/ReportService.kt b/src/main/kotlin/dev/dnpm/etl/processor/monitoring/ReportService.kt index ae36705..cc19d69 100644 --- a/src/main/kotlin/dev/dnpm/etl/processor/monitoring/ReportService.kt +++ b/src/main/kotlin/dev/dnpm/etl/processor/monitoring/ReportService.kt @@ -56,5 +56,6 @@ class ReportService( enum class Severity(@JsonValue val value: String) { ERROR("error"), WARNING("warning"), + INFO("info") } }
\ No newline at end of file diff --git a/src/main/resources/static/style.css b/src/main/resources/static/style.css index 203ac56..73fa08a 100644 --- a/src/main/resources/static/style.css +++ b/src/main/resources/static/style.css @@ -1,6 +1,9 @@ :root { --table-border: rgba(96, 96, 96, 1); + --bg-blue: rgb(0, 74, 157); + --bg-blue-op: rgba(0, 74, 157, .35); + --bg-green: rgb(0, 128, 0); --bg-green-op: rgba(0, 128, 0, .35); @@ -181,6 +184,15 @@ td { font-family: monospace; } +td.bg-blue, th.bg-blue { + background: var(--bg-blue); + color: white; +} + +tr:has(td.bg-blue) { + background: var(--bg-blue-op); +} + td.bg-green, th.bg-green { background: var(--bg-green); color: white; diff --git a/src/main/resources/templates/report.html b/src/main/resources/templates/report.html index d9087bf..4aaad68 100644 --- a/src/main/resources/templates/report.html +++ b/src/main/resources/templates/report.html @@ -45,6 +45,7 @@ </thead> <tbody> <tr th:each="issue : ${issues}"> + <td th:if="${issue.severity.value == 'info'}" class="bg-blue"><small>[[ ${issue.severity} ]]</small></td> <td th:if="${issue.severity.value == 'warning'}" class="bg-yellow"><small>[[ ${issue.severity} ]]</small></td> <td th:if="${issue.severity.value == 'error'}" class="bg-red"><small>[[ ${issue.severity} ]]</small></td> <td>[[ ${issue.message} ]]</td> diff --git a/src/test/kotlin/dev/dnpm/etl/processor/services/ReportServiceTest.kt b/src/test/kotlin/dev/dnpm/etl/processor/services/ReportServiceTest.kt index 70efe2b..6f85f4e 100644 --- a/src/test/kotlin/dev/dnpm/etl/processor/services/ReportServiceTest.kt +++ b/src/test/kotlin/dev/dnpm/etl/processor/services/ReportServiceTest.kt @@ -41,6 +41,7 @@ class ReportServiceTest { { "patient": "4711", "issues": [ + { "severity": "info", "message": "Info Message" }, { "severity": "warning", "message": "Warning Message" }, { "severity": "error", "message": "Error Message" } ] @@ -50,8 +51,10 @@ class ReportServiceTest { val actual = this.reportService.deserialize(json) assertThat(actual).hasSize(2) - assertThat(actual[0].severity).isEqualTo(ReportService.Severity.WARNING) - assertThat(actual[0].message).isEqualTo("Warning Message") + assertThat(actual[0].severity).isEqualTo(ReportService.Severity.INFO) + assertThat(actual[0].message).isEqualTo("Info Message") + assertThat(actual[1].severity).isEqualTo(ReportService.Severity.WARNING) + assertThat(actual[1].message).isEqualTo("Warning Message") assertThat(actual[1].severity).isEqualTo(ReportService.Severity.ERROR) assertThat(actual[1].message).isEqualTo("Error Message") } |
