refactor: use Fingerprint type instead of plain String

3 files changed, 19 insertions, 16 deletions

diff --git a/src/test/kotlin/dev/dnpm/etl/processor/services/RequestProcessorTest.kt b/src/test/kotlin/dev/dnpm/etl/processor/services/RequestProcessorTest.kt
index c82bccd..959db6b 100644
--- a/src/test/kotlin/dev/dnpm/etl/processor/services/RequestProcessorTest.kt
+++ b/src/test/kotlin/dev/dnpm/etl/processor/services/RequestProcessorTest.kt
@@ -21,6 +21,7 @@ package dev.dnpm.etl.processor.services
 
 import com.fasterxml.jackson.databind.ObjectMapper
 import de.ukw.ccc.bwhc.dto.*
+import dev.dnpm.etl.processor.Fingerprint
 import dev.dnpm.etl.processor.config.AppConfigProperties
 import dev.dnpm.etl.processor.monitoring.*
 import dev.dnpm.etl.processor.output.MtbFileSender
@@ -90,7 +91,7 @@ class RequestProcessorTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "zdlzv5s5ydmd4ktw2v5piohegc4jcyrm6j66bq6tv2uxuerndmga",
+                Fingerprint("zdlzv5s5ydmd4ktw2v5piohegc4jcyrm6j66bq6tv2uxuerndmga"),
                 RequestType.MTB_FILE,
                 RequestStatus.SUCCESS,
                 Instant.parse("2023-08-08T02:00:00Z")
@@ -149,7 +150,7 @@ class RequestProcessorTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "zdlzv5s5ydmd4ktw2v5piohegc4jcyrm6j66bq6tv2uxuerndmga",
+                Fingerprint("zdlzv5s5ydmd4ktw2v5piohegc4jcyrm6j66bq6tv2uxuerndmga"),
                 RequestType.MTB_FILE,
                 RequestStatus.SUCCESS,
                 Instant.parse("2023-08-08T02:00:00Z")
@@ -208,7 +209,7 @@ class RequestProcessorTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "different",
+                Fingerprint("different"),
                 RequestType.MTB_FILE,
                 RequestStatus.SUCCESS,
                 Instant.parse("2023-08-08T02:00:00Z")
@@ -271,7 +272,7 @@ class RequestProcessorTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "different",
+                Fingerprint("different"),
                 RequestType.MTB_FILE,
                 RequestStatus.SUCCESS,
                 Instant.parse("2023-08-08T02:00:00Z")
diff --git a/src/test/kotlin/dev/dnpm/etl/processor/services/RequestServiceTest.kt b/src/test/kotlin/dev/dnpm/etl/processor/services/RequestServiceTest.kt
index 02cd2cf..493fe37 100644
--- a/src/test/kotlin/dev/dnpm/etl/processor/services/RequestServiceTest.kt
+++ b/src/test/kotlin/dev/dnpm/etl/processor/services/RequestServiceTest.kt
@@ -19,6 +19,7 @@
 
 package dev.dnpm.etl.processor.services
 
+import dev.dnpm.etl.processor.Fingerprint
 import dev.dnpm.etl.processor.monitoring.Request
 import dev.dnpm.etl.processor.monitoring.RequestRepository
 import dev.dnpm.etl.processor.monitoring.RequestStatus
@@ -45,7 +46,7 @@ class RequestServiceTest {
         UUID.randomUUID().toString(),
         "TEST_dummy",
         "PX",
-        "dummy",
+        Fingerprint("dummy"),
         RequestType.MTB_FILE,
         RequestStatus.SUCCESS,
         Instant.parse("2023-08-08T02:00:00Z")
@@ -67,7 +68,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.MTB_FILE,
                 RequestStatus.WARNING,
                 Instant.parse("2023-07-07T00:00:00Z")
@@ -77,7 +78,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdefd",
+                Fingerprint("0123456789abcdefd"),
                 RequestType.DELETE,
                 RequestStatus.WARNING,
                 Instant.parse("2023-07-07T02:00:00Z")
@@ -87,7 +88,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.MTB_FILE,
                 RequestStatus.UNKNOWN,
                 Instant.parse("2023-08-11T00:00:00Z")
@@ -107,7 +108,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.MTB_FILE,
                 RequestStatus.WARNING,
                 Instant.parse("2023-07-07T00:00:00Z")
@@ -117,7 +118,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.MTB_FILE,
                 RequestStatus.WARNING,
                 Instant.parse("2023-07-07T02:00:00Z")
@@ -127,7 +128,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.MTB_FILE,
                 RequestStatus.UNKNOWN,
                 Instant.parse("2023-08-11T00:00:00Z")
@@ -147,7 +148,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678901",
                 "P1",
-                "0123456789abcdef1",
+                Fingerprint("0123456789abcdef1"),
                 RequestType.DELETE,
                 RequestStatus.SUCCESS,
                 Instant.parse("2023-07-07T02:00:00Z")
@@ -157,7 +158,7 @@ class RequestServiceTest {
                 UUID.randomUUID().toString(),
                 "TEST_12345678902",
                 "P2",
-                "0123456789abcdef2",
+                Fingerprint("0123456789abcdef2"),
                 RequestType.MTB_FILE,
                 RequestStatus.WARNING,
                 Instant.parse("2023-08-08T00:00:00Z")
@@ -167,7 +168,7 @@ class RequestServiceTest {
         val actual = RequestService.lastMtbFileRequestForPatientPseudonym(requests)
 
         assertThat(actual).isInstanceOf(Request::class.java)
-        assertThat(actual?.fingerprint).isEqualTo("0123456789abcdef2")
+        assertThat(actual?.fingerprint).isEqualTo(Fingerprint("0123456789abcdef2"))
     }
 
     @Test
@@ -190,7 +191,7 @@ class RequestServiceTest {
             UUID.randomUUID().toString(),
             "TEST_12345678901",
             "P1",
-            "0123456789abcdef1",
+            Fingerprint("0123456789abcdef1"),
             RequestType.DELETE,
             RequestStatus.SUCCESS,
             Instant.parse("2023-07-07T02:00:00Z")
diff --git a/src/test/kotlin/dev/dnpm/etl/processor/services/ResponseProcessorTest.kt b/src/test/kotlin/dev/dnpm/etl/processor/services/ResponseProcessorTest.kt
index b9e4b7f..c96fe8f 100644
--- a/src/test/kotlin/dev/dnpm/etl/processor/services/ResponseProcessorTest.kt
+++ b/src/test/kotlin/dev/dnpm/etl/processor/services/ResponseProcessorTest.kt
@@ -19,6 +19,7 @@
 
 package dev.dnpm.etl.processor.services
 
+import dev.dnpm.etl.processor.Fingerprint
 import dev.dnpm.etl.processor.monitoring.Request
 import dev.dnpm.etl.processor.monitoring.RequestRepository
 import dev.dnpm.etl.processor.monitoring.RequestStatus
@@ -50,7 +51,7 @@ class ResponseProcessorTest {
         "TestID1234",
         "PSEUDONYM-A",
         "1",
-        "dummyfingerprint",
+        Fingerprint("dummyfingerprint"),
         RequestType.MTB_FILE,
         RequestStatus.UNKNOWN
     )