1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
|
package dev.dnpm.security;
import de.itc.onkostar.api.IOnkostarApi;
import de.itc.onkostar.api.Patient;
import de.itc.onkostar.api.Procedure;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.aop.aspectj.annotation.AspectJProxyFactory;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.*;
@ExtendWith(MockitoExtension.class)
class FormBasedSecurityAspectsTest {
private DummyClass dummyClass;
private IOnkostarApi onkostarApi;
private FormBasedPermissionEvaluator permissionEvaluator;
@BeforeEach
void setup(
@Mock IOnkostarApi onkostarApi,
@Mock FormBasedPermissionEvaluator permissionEvaluator
) {
this.onkostarApi = onkostarApi;
this.permissionEvaluator = permissionEvaluator;
// Create proxied instance of DummyClass as done within Onkostar using Spring AOP
var dummyClass = new DummyClass(onkostarApi);
AspectJProxyFactory factory = new AspectJProxyFactory(dummyClass);
FormBasedSecurityAspects securityAspects = new FormBasedSecurityAspects(this.permissionEvaluator);
factory.addAspect(securityAspects);
this.dummyClass = factory.getProxy();
}
@Test
void testShouldAllowSecuredMethodCallWithPatientParam() {
this.dummyClass.methodWithPatientParam(new Patient(onkostarApi));
verify(onkostarApi, times(1)).savePatient(any(Patient.class));
}
@Test
void testShouldPreventSecuredMethodCallWithProcedureParam() {
when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
.thenReturn(false);
var exception = assertThrows(
Exception.class,
() -> this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi))
);
assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
}
@Test
void testShouldAllowSecuredMethodCallWithProcedureParam() throws Exception {
when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
.thenReturn(true);
this.dummyClass.methodWithProcedureParam(new Procedure(onkostarApi));
verify(onkostarApi, times(1)).saveProcedure(any(Procedure.class), anyBoolean());
}
@Test
void testShouldAllowSecuredMethodCallWithPatientReturnValue() {
var actual = this.dummyClass.methodWithPatientReturnValue(1);
assertThat(actual).isNotNull();
}
@Test
void testShouldPreventSecuredMethodCallWithProcedureReturnValue() {
when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
.thenReturn(false);
var exception = assertThrows(
Exception.class,
() -> this.dummyClass.methodWithProcedureReturnValue(1)
);
assertThat(exception).isExactlyInstanceOf(IllegalSecuredObjectAccessException.class);
}
@Test
void testShouldAllowSecuredMethodCallWithProcedureReturnValue() {
when(this.permissionEvaluator.hasPermission(any(), any(Procedure.class), any(PermissionType.class)))
.thenReturn(true);
var actual = this.dummyClass.methodWithProcedureReturnValue(1);
assertThat(actual).isNotNull();
}
private static class DummyClass {
private final IOnkostarApi onkostarApi;
DummyClass(final IOnkostarApi onkostarApi) {
this.onkostarApi = onkostarApi;
}
@FormSecured
public void methodWithPatientParam(Patient patient) {
this.onkostarApi.savePatient(patient);
}
@FormSecured
public void methodWithProcedureParam(Procedure procedure) throws Exception {
this.onkostarApi.saveProcedure(procedure, false);
}
@FormSecuredResult
public Patient methodWithPatientReturnValue(int id) {
var patient = new Patient(this.onkostarApi);
patient.setId(id);
return patient;
}
@FormSecuredResult
public Procedure methodWithProcedureReturnValue(int id) {
var procedure = new Procedure(this.onkostarApi);
procedure.setId(id);
return procedure;
}
}
}
|
